Repository navigation
Fix transient server errors reported as dead links - #300
Merged
TMHSDigital merged 2 commits intoNov 10, 2026
Merged
Conversation
On Windows an absolute path like C:\... is read as a URL with scheme "c:", so the TMHSDigital#275 CLI test failed with ERR_UNSUPPORTED_ESM_URL_SCHEME. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpkeXPtfg3jGzhfoGMshTE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix transient server errors reported as dead links
Fixes #275.
HTTP 502/503/504 responses now use
kind: "unavailable"and appear under Could not check, without increasing theproblemsoutput used for the report issue's “sources need a look” count. This covers both catalog source URLs and licence pages quoted in Evidence or linked in Notes. The existing single retry is retained, including recovery to HTTP 200. The handling of other statuses, including 404/410 and 401/403/429, is preserved.Related: #299 addresses the same classification issue. This alternative also includes
unavailablein the retry condition and reports temporarily unavailable Evidence/Notes URLs, with CLI regression coverage for both behaviors and the problem count.Regression tests in
site/lib/lib.test.mjscover classification and run the real CLI against an isolated catalog with mocked DNS and HTTP. An outage-only fixture now producesproblems=0; a mixed fixture counts only the four genuinely dead source/licence links. Existing GitHub API failures remain visible under Could not check.Validation:
npm run checkpassed locally after rebasing ontoea44b24, on Node.js v22.22.3 (lint, 274 catalog assertions, 1,741 library assertions, validate, check-added and build). Before the production fix, the new regression checks reproduced the inflated problem counts.Prepared with AI assistance. This change modifies checker logic and tests only; no catalog or licence facts are changed.
Type
Checklist
npm test && npm run validatepasses locally (the fullnpm run checkalso passed)Catalog-entry and starter-stack checklist items do not apply.